WASM_X86: Support exit code #1285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
certik
approved these changes
Nov 10, 2022
ubaidsk
force-pushed
the
wasm_x86_exit_code
branch
from
8dbcf33 to
2b0e213
Compare
(without pushing it to unique_id)
ubaidsk
force-pushed
the
wasm_x86_exit_code
branch
from
18680fc to
ad6c486
Compare
Yes, got it. I just added it in commit WASM_X86: Add comments about emit_exit2() and X86Visitor stack working. |
|
There are some (supporting) tests activated/enabled for the |
|
As this seems approved, I am adding this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #1222